fix: Make spec uploads persistent #8
Merged
+66
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discourse routinely removes uploads that are not tied to posts anymore. The way we uploaded was not recognized as a file usage, since we used the file URL of the file in the storage instead of the discourse upload URL. That worked, until the clean up kicked in and removed the spec files. This PR uses the upload URL now and puts in an additional link to the file for good measure. It also adds a header line, so the post shows up in the category overview more nicely.
jonasmeier1212
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discourse routinely removes uploads that are not tied to posts anymore. The way we uploaded was not recognized as a file usage, since we used the file URL of the file in the storage instead of the discourse upload URL. That worked, until the clean up kicked in and removed the spec files.
This PR uses the upload URL now and puts in an additional link to the file for good measure.
It also adds a header line, so the post shows up in the category overview more nicely.